Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate for 1.30, fix patches #3680

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Regenerate for 1.30, fix patches #3680

merged 1 commit into from
Oct 3, 2024

Conversation

brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Sep 9, 2024 •
edited
Loading

@yue9944882 I regenerated for 1.30 including the fixes for nullable arrays, also fixed up the patches so they applied cleanly.

Ref #3076

Please take a look.

Tests are failing b/c the YAML is being generated with empty lists intead of nulls, I'm not sure this is easily fixable but will investigate.

YAML is fixed, but one JSON test is failing and needs a fix.

This is ready for review.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 9, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: yue9944882 / name: Min Jin (b552ede)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2024
@brendandburns brendandburns force-pushed the automated-generate-fbd1cb18 branch from f1432c3 to bf396ae Compare September 9, 2024 22:12
@brendandburns brendandburns changed the title Regenerate for 1.30, fix patches [WIP] Regenerate for 1.30, fix patches Sep 9, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@brendandburns brendandburns force-pushed the automated-generate-fbd1cb18 branch from bf396ae to 077ed83 Compare September 9, 2024 23:23
@brendandburns
Copy link
Contributor Author

Ok, I updated this so that empty lists are omitted from YAML dumping and I think that should be ok.

@brendandburns brendandburns force-pushed the automated-generate-fbd1cb18 branch from 077ed83 to b15e806 Compare September 9, 2024 23:25
@yue9944882
Copy link
Member 

Error:    KubectlDeleteTest.kubectlDelete:216 No requests exactly matched. Most similar request was:  expected:<
DELETE
/apis/batch%2Fv1/batch%2Fv1/namespaces/foo/jobs/bar

[equalToJson]
{
  "propagationPolicy" : "Foreground"
}> but was:<
DELETE
/apis/batch%2Fv1/batch%2Fv1/namespaces/foo/jobs/bar


{
  "dryRun" : [ ],
  "propagationPolicy" : "Foreground"
}>

it looks like k/k api added a new dry-run option for delete API, so we need to align with that. i will append another commit to fix it

@brendandburns brendandburns force-pushed the automated-generate-fbd1cb18 branch 2 times, most recently from 08e8fa2 to 5dac2ce Compare September 26, 2024 19:47
@brendandburns
Copy link
Contributor Author

@yue9944882 this is fixed up and ready to review, I tried to keep the commits separate for easier reviewing, but I'll likely squash them in the end to fix the issues with authorship and the PR bot.

I had to remove a check from KubectlDrain.java to get tests to pass, but I'm not sure that it really made sense in the first place anyway. Also added an exclusion strategy to GSON for metadata.managedFields

@brendandburns brendandburns force-pushed the automated-generate-fbd1cb18 branch from 36ed886 to 3844f99 Compare September 26, 2024 19:56
@yue9944882
Copy link
Member

EasyCLA — Missing CLA Authorization.

This PR failed CLA check due to bot commit, let me squash the branch into single commit to workaround

@yue9944882
Regenerate for 1.30, fix patches
b552ede 
Signed-off-by: Min Jin <minkimzz@amazon.com>
@yue9944882 yue9944882 force-pushed the automated-generate-fbd1cb18 branch from 3844f99 to b552ede Compare October 3, 2024 05:05
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 3, 2024
@brendandburns
Copy link
Contributor Author

manual lgtm, since I'm the original author of the PR.

@brendandburns brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 3, 2024
@brendandburns brendandburns changed the title [WIP] Regenerate for 1.30, fix patches Regenerate for 1.30, fix patches Oct 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9197d0b into kubernetes-client:master Oct 3, 2024
18 checks passed
@brendandburns brendandburns mentioned this pull request Oct 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendandburns @k8s-ci-robot @yue9944882